EDUCATIC
/
digitaldemocratic
mirror of https://gitlab.com/digitaldemocratic/digitaldemocratic
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update contributing.md

merge-requests/85/head
Aleix Quintana Alsius 2023-04-23 18:46:19 +00:00
parent e87d1188cf
commit 1eb8cc23a1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/contributing.md
View File

@ -72,7 +72,7 @@ To simplify the review work and to ensure certain quality of what is integrated
- Nobody can `push` commits directly to `main` branch (`main`).
Always is necessary to follow the [Merge Request][mr] review proces.
- ** TO BE REVIEWED ( branch based events?? )** There is a [buildbot][buildbot] instance (in `ci.dd-work.space`, login via GitLab) as a Continuous Integration that reacts to `push` events in `main` branch and to [Merge Request][mr] events in any other branch.
- There is a [buildbot][buildbot] instance (in `ci.dd-work.space`, login via GitLab) as a Continuous Integration, that reacts to `push` events in `main` branch and to [Merge Request][mr] events in any other branch.
- When the event is a [Merge Request][mr], only static checks are executed, so no complete tests are launched.
This is to prevent crypto mining CI/CD abuse.
These checks are [ShellCheck][sc] for shell scripts, [mkdocs][mkdocs] to check that the documentation is generated as it should. Also, we will add soon linters and standard python checks.
@ -103,4 +103,4 @@ Before integrating a Merge Request, we need to make sure that this checklist is
If any of these steps fails, we'll try to help whoever has requested the code merge to solve the problems.
[buildbot]: https://buildbot.net
[pola]: https://en.wikipedia.org/wiki/Principle_of_least_astonishment
[pola]: https://en.wikipedia.org/wiki/Principle_of_least_astonishment