From 1eb8cc23a11bed30475b409919e4e6b6b5d3fefa Mon Sep 17 00:00:00 2001 From: Aleix Quintana Alsius Date: Sun, 23 Apr 2023 18:46:19 +0000 Subject: [PATCH] Update contributing.md --- docs/contributing.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/contributing.md b/docs/contributing.md index 4ff20e2..e4b9ec5 100644 --- a/docs/contributing.md +++ b/docs/contributing.md @@ -72,7 +72,7 @@ To simplify the review work and to ensure certain quality of what is integrated - Nobody can `push` commits directly to `main` branch (`main`). Always is necessary to follow the [Merge Request][mr] review proces. -- ** TO BE REVIEWED ( branch based events?? )** There is a [buildbot][buildbot] instance (in `ci.dd-work.space`, login via GitLab) as a Continuous Integration that reacts to `push` events in `main` branch and to [Merge Request][mr] events in any other branch. +- There is a [buildbot][buildbot] instance (in `ci.dd-work.space`, login via GitLab) as a Continuous Integration, that reacts to `push` events in `main` branch and to [Merge Request][mr] events in any other branch. - When the event is a [Merge Request][mr], only static checks are executed, so no complete tests are launched. This is to prevent crypto mining CI/CD abuse. These checks are [ShellCheck][sc] for shell scripts, [mkdocs][mkdocs] to check that the documentation is generated as it should. Also, we will add soon linters and standard python checks. @@ -103,4 +103,4 @@ Before integrating a Merge Request, we need to make sure that this checklist is If any of these steps fails, we'll try to help whoever has requested the code merge to solve the problems. [buildbot]: https://buildbot.net -[pola]: https://en.wikipedia.org/wiki/Principle_of_least_astonishment \ No newline at end of file +[pola]: https://en.wikipedia.org/wiki/Principle_of_least_astonishment