release: 2.3.1 🎉

fix: convert boolean columns to not nullable

.github/workflows/php-test.yml

@@ -39,7 +39,7 @@ jobs:
         path: nextcloud/apps/bbb
     - name: Update test stub
       working-directory: nextcloud/apps/bbb
-      run: composer update christophwurst/nextcloud -W
+      run: composer update friendsofphp/php-cs-fixer christophwurst/nextcloud -W
     - name: Install dependencies
       working-directory: nextcloud/apps/bbb
       run: composer install

.github/workflows/static.yml

@@ -16,9 +16,12 @@ jobs:
           with:
             php-version: 7.4
             coverage: none
+        - name: Update php-cs-fixer
+          run: composer update friendsofphp/php-cs-fixer -W
         - name: Install dependencies
           run: composer i
         - name: Install dependencies
           run: composer require --dev christophwurst/nextcloud:${{ matrix.ocp-version }}
         - name: Run coding standards check
-          run: composer run psalm
+          run: composer run psalm
+

CHANGELOG.md

@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## 2.3.1 (2022-07-28)
+### Fixed
+- broken build
+- convert boolean columns to not nullable
+
 ## 2.3.0 (2022-07-24)
 ### Added
 - [#191](https://github.com/sualko/cloud_bbb/issues/191) clone rooms

appinfo/info.xml

@@ -22,7 +22,7 @@ Developer wanted! If you have time it would be awesome if you could help to enha
 
 *This app integrates BigBlueButton and is not endorsed or certified by BigBlueButton Inc. BigBlueButton and the BigBlueButton Logo are trademarks of BigBlueButton Inc.*
     ]]></description>
-    <version>2.3.0</version>
+    <version>2.3.1</version>
     <licence>agpl</licence>
     <author mail="klaus@jsxc.org">Klaus Herberth</author>
     <namespace>BigBlueButton</namespace>

lib/Migration/Version000000Date20220728083700.php

@@ -0,0 +1,49 @@
+<?php
+
+declare(strict_types=1);
+
+namespace OCA\BigBlueButton\Migration;
+
+use Closure;
+use OCP\DB\ISchemaWrapper;
+use OCP\Migration\IOutput;
+use OCP\Migration\SimpleMigrationStep;
+
+/**
+ * Auto-generated migration step: Please modify to your needs!
+ */
+class Version000000Date20220728083700 extends SimpleMigrationStep {
+
+
+	/**
+	 * @param IOutput $output
+	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+	 * @param array $options
+	 * @return null|ISchemaWrapper
+	 */
+	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+		/** @var ISchemaWrapper $schema */
+		$schema = $schemaClosure();
+
+		$this->convertToNotNullable($schema, 'bbb_rooms', 'record');
+		$this->convertToNotNullable($schema, 'bbb_rooms', 'everyone_is_moderator');
+		$this->convertToNotNullable($schema, 'bbb_rooms', 'require_moderator');
+		$this->convertToNotNullable($schema, 'bbb_rooms', 'listen_only');
+		$this->convertToNotNullable($schema, 'bbb_rooms', 'media_check');
+		$this->convertToNotNullable($schema, 'bbb_rooms', 'clean_layout');
+
+		$this->convertToNotNullable($schema, 'bbb_restrictions', 'allow_recording');
+
+		return null;
+	}
+
+	private function convertToNotNullable(ISchemaWrapper $schema, string $table, string $column): void {
+		if ($schema->hasTable($table)) {
+			$table = $schema->getTable('bbb_rooms');
+
+			if ($table->hasColumn($column) && $table->getColumn($column)->getNotnull()) {
+				$table->getColumn($column)->setNotnull(false);
+			}
+		}
+	}
+}

package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@sualko/cloud_bbb",
 	"description": "Nextcloud Integration for BigBlueButton",
-	"version": "2.3.0",
+	"version": "2.3.1",
 	"author": "Klaus Herberth <klaus@jsxc.org>",
 	"bugs": {
 		"url": "https://github.com/sualko/cloud_bbb/issues"
@@ -28,8 +28,8 @@
 		"lint:fix:style": "stylelint 'ts/**/*.scss' --fix",
 		"lint:php": "./vendor/bin/php-cs-fixer fix --dry-run",
 		"lint:fix:php": "./vendor/bin/php-cs-fixer fix",
-		"composer:install": "composer install --no-dev -o",
-		"composer:install:dev": "composer install -o",
+		"composer:install": "composer install --no-dev",
+		"composer:install:dev": "composer install",
 		"release:build": "node scripts/build-release.js",
 		"release:publish": "node scripts/publish-release.js"
 	},

psalm.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0"?>
 <psalm
-    totallyTyped="true"
     errorLevel="5"
     resolveFromConfigFile="true"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

tests/psalm-baseline.xml

@@ -1,7 +1,28 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="4.8.1@f73f2299dbc59a3e6c4d66cff4605176e728ee69">
+<files psalm-version="4.24.0@06dd975cb55d36af80f242561738f16c5f58264f">
+  <file src="lib/AppInfo/Application.php">
+    <InvalidArgument occurrences="8">
+      <code>addServiceListener</code>
+      <code>addServiceListener</code>
+      <code>addServiceListener</code>
+      <code>addServiceListener</code>
+      <code>addServiceListener</code>
+      <code>addServiceListener</code>
+      <code>addServiceListener</code>
+      <code>addServiceListener</code>
+    </InvalidArgument>
+  </file>
+  <file src="lib/BigBlueButton/API.php">
+    <UndefinedClass occurrences="1">
+      <code>InsertDocumentParameters</code>
+    </UndefinedClass>
+    <UndefinedMethod occurrences="1">
+      <code>insertDocument</code>
+    </UndefinedMethod>
+  </file>
   <file src="lib/CircleHelper.php">
     <UndefinedClass occurrences="3">
+      <code>\OCA\Circles\Api\v1\Circles</code>
       <code>\OCA\Circles\Api\v1\Circles</code>
       <code>\OCA\Circles\Model\Member</code>
     </UndefinedClass>
@@ -11,12 +32,6 @@
       <code>null</code>
     </NullArgument>
   </file>
-  <file src="lib/Controller/ServerController.php">
-    <InvalidArgument occurrences="2">
-      <code>$success</code>
-      <code>$this-&gt;server-&gt;check($url, $secret)</code>
-    </InvalidArgument>
-  </file>
   <file src="lib/NoPermissionResponse.php">
     <MissingDependency occurrences="1">
       <code>Template</code>