From dd7bd97cb3450f3cc02946af1672a9b245936e20 Mon Sep 17 00:00:00 2001 From: sualko Date: Wed, 26 Aug 2020 10:53:00 +0200 Subject: [PATCH] refactor: remove obsolete config injection --- lib/Controller/JoinController.php | 6 ------ tests/Unit/Controller/JoinControllerTest.php | 4 ---- 2 files changed, 10 deletions(-) diff --git a/lib/Controller/JoinController.php b/lib/Controller/JoinController.php index 2738e77..a311cbc 100644 --- a/lib/Controller/JoinController.php +++ b/lib/Controller/JoinController.php @@ -12,7 +12,6 @@ use OCP\AppFramework\Http\RedirectResponse; use OCP\IRequest; use OCP\IURLGenerator; use OCP\IUserSession; -use OCP\IConfig; use OCA\BigBlueButton\Service\RoomService; use OCP\AppFramework\Controller; use OCP\AppFramework\Http\TemplateResponse; @@ -33,9 +32,6 @@ class JoinController extends Controller { /** @var IUserSession */ private $userSession; - /** @var IConfig */ - private $config; - /** @var API */ private $api; @@ -48,7 +44,6 @@ class JoinController extends Controller { RoomService $service, IURLGenerator $urlGenerator, IUserSession $userSession, - IConfig $config, API $api, Permission $permission ) { @@ -57,7 +52,6 @@ class JoinController extends Controller { $this->service = $service; $this->urlGenerator = $urlGenerator; $this->userSession = $userSession; - $this->config = $config; $this->api = $api; $this->permission = $permission; } diff --git a/tests/Unit/Controller/JoinControllerTest.php b/tests/Unit/Controller/JoinControllerTest.php index e630867..d5edb37 100644 --- a/tests/Unit/Controller/JoinControllerTest.php +++ b/tests/Unit/Controller/JoinControllerTest.php @@ -6,7 +6,6 @@ use PHPUnit\Framework\TestCase; use OCP\AppFramework\Http\RedirectResponse; use OCP\IURLGenerator; use OCP\IUserSession; -use OCP\IConfig; use OCP\IRequest; use OCP\IUser; use OCA\BigBlueButton\Service\RoomService; @@ -22,7 +21,6 @@ class JoinControllerTest extends TestCase { private $request; private $service; private $userSession; - private $config; private $urlGenerator; private $controller; private $api; @@ -35,7 +33,6 @@ class JoinControllerTest extends TestCase { $this->request = $this->createMock(IRequest::class); $this->service = $this->createMock(RoomService::class); $this->userSession = $this->createMock(IUserSession::class); - $this->config = $this->createMock(IConfig::class); $this->urlGenerator = $this->createMock(IURLGenerator::class); $this->api = $this->createMock(API::class); $this->permission = $this->createMock(Permission::class); @@ -46,7 +43,6 @@ class JoinControllerTest extends TestCase { $this->service, $this->urlGenerator, $this->userSession, - $this->config, $this->api, $this->permission );