From facea236cee7c1913c2fcf72147bc9fe68dfa028 Mon Sep 17 00:00:00 2001 From: Paal Joergensen Date: Fri, 4 Aug 2017 12:03:30 +0200 Subject: [PATCH 1/2] Making timing better for new score bar [HFP-1229] --- js/questionset.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/questionset.js b/js/questionset.js index 0a29e99..a407b42 100644 --- a/js/questionset.js +++ b/js/questionset.js @@ -772,7 +772,6 @@ H5P.QuestionSet = function (options, contentId, contentData) { scoreBar = H5P.JoubelUI.createScoreBar(totals); } scoreBar.appendTo($('.feedback-scorebar', $myDom)); - scoreBar.setScore(finals); $('.feedback-text', $myDom).html(scoreString); // Announce that the question set is complete @@ -783,6 +782,7 @@ H5P.QuestionSet = function (options, contentId, contentData) { eparams.comment + '.' + eparams.resulttext) .show().focus(); + scoreBar.setScore(finals); }, 0); } else { From 6d63bdc43c5a550602de7396b81e498b5506313c Mon Sep 17 00:00:00 2001 From: Paal Joergensen Date: Mon, 7 Aug 2017 11:43:46 +0200 Subject: [PATCH 2/2] HFP-1339 Making overall feedback expanded and changing description --- semantics.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/semantics.json b/semantics.json index a200f25..bd8e8e8 100644 --- a/semantics.json +++ b/semantics.json @@ -287,6 +287,7 @@ "type": "group", "label": "Overall Feedback", "importance": "low", + "expanded": true, "fields": [ { "name": "overallFeedback", @@ -299,7 +300,7 @@ ], "importance": "high", "label": "Define custom feedback for any score range", - "description": "Example: 0-20% Bad score, 21-91% Average Score, 91-100% Great Score!", + "description": "Click the \"Add range\" button to add as many ranges as you need. Example: 0-20% Bad score, 21-91% Average Score, 91-100% Great Score!", "entity": "range", "min": 1, "defaultNum": 1,