Added confirmation dialog functionality when disabling hub.

Refactored server setup check into check and var updates.
Moved bytes string parsing out of server setup check and fixed naming convention.
Fixed indentation to match library core instead of Moodle style.

h5p.classes.php

@@ -2760,9 +2760,11 @@ class H5PCore {
   }
 
   /**
-     * Check that all H5P requirements for the server setup is met.
+   * Check if the current server setup is valid and set error messages
+   *
+   * @return bool True if errors was found
    */
-  public function checkSetupForRequirements() {
+  public function checkSetupErrorMessage() {
     $disable_hub = FALSE;
 
     if (!class_exists('ZipArchive')) {
@@ -2786,32 +2788,16 @@ class H5PCore {
       $disable_hub = TRUE;
     }
 
-      // Check max upload and post size
-      function return_bytes($val) {
-          $val = trim($val);
-          $last = strtolower($val[strlen($val)-1]);
-          switch($last) {
-              case 'g':
-                  $val *= 1024;
-              case 'm':
-                  $val *= 1024;
-              case 'k':
-                  $val *= 1024;
-          }
-
-          return $val;
-      }
-
     $max_upload_size = ini_get('upload_max_filesize');
     $max_post_size   = ini_get('post_max_size');
     $byte_threshold  = 5000000; // 5MB
-      if (return_bytes($max_upload_size) < $byte_threshold) {
+    if (self::returnBytes($max_upload_size) < $byte_threshold) {
       $this->h5pF->setErrorMessage(
         $this->h5pF->t('Your PHP max upload size option is too small. You should consider to increase it to more than 5MB.')
       );
     }
 
-      if (return_bytes($max_post_size) < $byte_threshold) {
+    if (self::returnBytes($max_post_size) < $byte_threshold) {
       $this->h5pF->setErrorMessage(
         $this->h5pF->t('Your PHP max post size option is too small. You should consider to increase it to more than 5MB.')
       );
@@ -2825,6 +2811,15 @@ class H5PCore {
       $disable_hub = TRUE;
     }
 
+    return $disable_hub;
+  }
+
+  /**
+   * Check that all H5P requirements for the server setup is met.
+   */
+  public function checkSetupForRequirements() {
+    $disable_hub = $this->checkSetupErrorMessage();
+
     // Disable hub, and inform how to re-enable it
     $this->h5pF->setOption('disable_hub', $disable_hub);
     if ($disable_hub) {
@@ -2836,6 +2831,28 @@ class H5PCore {
       );
     }
   }
+
+  /**
+   * Return bytes from php_ini string value
+   *
+   * @param string $val
+   *
+   * @return int|string
+   */
+  public static function returnBytes($val) {
+    $val  = trim($val);
+    $last = strtolower($val[strlen($val) - 1]);
+    switch ($last) {
+      case 'g':
+        $val *= 1024;
+      case 'm':
+        $val *= 1024;
+      case 'k':
+        $val *= 1024;
+    }
+
+    return $val;
+  }
 }
 
 /**

js/settings/h5p-disable-hub.js

@@ -0,0 +1,66 @@
+/* global H5PDisableHubData */
+
+/**
+ * Global data for disable hub functionality
+ *
+ * @typedef {object} H5PDisableHubData Data passed in from the backend
+ *
+ * @property {string} selector Selector for the disable hub check-button
+ * @property {string} overlaySelector Selector for the element that the confirmation dialog will mask
+ * @property {Array} errors Errors found with the current server setup
+ *
+ * @property {string} header Header of the confirmation dialog
+ * @property {string} confirmationDialogMsg Body of the confirmation dialog
+ * @property {string} cancelLabel Cancel label of the confirmation dialog
+ * @property {string} confirmLabel Confirm button label of the confirmation dialog
+ *
+ */
+/**
+ * Utility that makes it possible to force the user to confirm that he really
+ * wants to use the H5P hub without proper server settings.
+ */
+(function ($) {
+
+
+
+  $(document).on('ready', function () {
+
+    // No data found
+    if (!H5PDisableHubData) {
+      return;
+    }
+
+    // No errors found, no need for confirmation dialog
+    if (!H5PDisableHubData.errors || !H5PDisableHubData.errors.length) {
+      return;
+    }
+
+    var selector = H5PDisableHubData.selector;
+    var dialogHtml = '<div>' +
+      '<p>' + H5PDisableHubData.errors.join('</p><p>') + '</p>' +
+      '<p>' + H5PDisableHubData.confirmationDialogMsg + '</p>';
+
+    // Create confirmation dialog, make sure to include translations
+    var confirmationDialog = new H5P.ConfirmationDialog({
+      headerText: H5PDisableHubData.header,
+      dialogText: dialogHtml,
+      cancelText: H5PDisableHubData.cancelLabel,
+      confirmText: H5PDisableHubData.confirmLabel
+    }).appendTo($(H5PDisableHubData.overlaySelector).get(0));
+
+    confirmationDialog.on('confirmed', function () {
+      disableButton.get(0).checked = false;
+    });
+
+    confirmationDialog.on('canceled', function () {
+      disableButton.get(0).checked = true;
+    });
+
+    var disableButton = $(selector);
+    disableButton.change(function () {
+      if (!$(this).is(':checked')) {
+        confirmationDialog.show(disableButton.offset().top);
+      }
+    });
+  });
+})(H5P.jQuery);