EDUCATIC
/
h5p-php-library
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove tabindex of exitButton in confirmation dialog. 

Trapped focus between confirm and cancel button.
HFJ-2004
pull/22/head
Thomas Marstrander 2016-06-09 15:26:15 +02:00
parent 51851f14c3
commit b3c55928e3
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
js/h5p-confirmation-dialog.js
View File

@ -16,7 +16,7 @@ H5P.ConfirmationDialog = (function (EventDispatcher) {
function ConfirmationDialog(options) { function ConfirmationDialog(options) {
EventDispatcher.call(this); EventDispatcher.call(this);
var self = this; var self = this;
// Make sure confirmation dialogs have unique id // Make sure confirmation dialogs have unique id
H5P.ConfirmationDialog.uniqueId += 1; H5P.ConfirmationDialog.uniqueId += 1;
var uniqueId = H5P.ConfirmationDialog.uniqueId; var uniqueId = H5P.ConfirmationDialog.uniqueId;
@ -126,6 +126,7 @@ H5P.ConfirmationDialog = (function (EventDispatcher) {
var exitButton = document.createElement('button'); var exitButton = document.createElement('button');
exitButton.classList.add('h5p-confirmation-dialog-exit'); exitButton.classList.add('h5p-confirmation-dialog-exit');
exitButton.setAttribute('aria-hidden', 'true'); exitButton.setAttribute('aria-hidden', 'true');
exitButton.tabIndex = -1;
exitButton.title = options.cancelText; exitButton.title = options.cancelText;
// Cancel handler // Cancel handler
@ -135,7 +136,7 @@ H5P.ConfirmationDialog = (function (EventDispatcher) {
dialogCanceled(e); dialogCanceled(e);
} }
else if (e.which === 9 && e.shiftKey) { // Shift-tab else if (e.which === 9 && e.shiftKey) { // Shift-tab
flowTo(exitButton, e); flowTo(confirmButton, e);
} }
}); });
buttons.appendChild(cancelButton); buttons.appendChild(cancelButton);
@ -146,6 +147,9 @@ H5P.ConfirmationDialog = (function (EventDispatcher) {
if (e.which === 32) { // Space if (e.which === 32) { // Space
dialogConfirmed(e); dialogConfirmed(e);
} }
else if (e.which === 9 && !e.shiftKey) { // Tab
flowTo(cancelButton, e);
}
}); });
buttons.appendChild(confirmButton); buttons.appendChild(confirmButton);
@ -155,9 +159,6 @@ H5P.ConfirmationDialog = (function (EventDispatcher) {
if (e.which === 32) { // Space if (e.which === 32) { // Space
dialogCanceled(e); dialogCanceled(e);
} }
else if (e.which === 9 && !e.shiftKey) { // Tab
flowTo(cancelButton, e);
}
}); });
popup.appendChild(exitButton); popup.appendChild(exitButton);