From bfb7b5600c963c1825fcbe7f247b4d584cedb58e Mon Sep 17 00:00:00 2001 From: Oliver Tacke Date: Fri, 11 Jan 2019 14:52:10 +0100 Subject: [PATCH 1/2] Fix missing closing div for close button --- js/h5p.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/h5p.js b/js/h5p.js index c25520c..9727ece 100644 --- a/js/h5p.js +++ b/js/h5p.js @@ -925,7 +925,7 @@ H5P.Dialog = function (name, title, content, $element) {
\

' + title + '

\
' + content + '
\ -
\ +
\
\
') .insertAfter($element) From b6080a1a00476ff9a8abad187ac40c7e39da38fe Mon Sep 17 00:00:00 2001 From: Frode Petterson Date: Mon, 14 Jan 2019 15:26:27 +0100 Subject: [PATCH 2/2] Update FS comment --- js/h5p.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/js/h5p.js b/js/h5p.js index c25520c..949945a 100644 --- a/js/h5p.js +++ b/js/h5p.js @@ -75,8 +75,9 @@ H5P.init = function (target) { * @type {boolean} */ H5P.fullscreenSupported = !(H5P.isFramed && H5P.externalEmbed !== false) || !!(document.fullscreenEnabled || document.webkitFullscreenEnabled || document.mozFullScreenEnabled); - // We should consider document.msFullscreenEnabled when they get their - // element sizing corrected. Ref. https://connect.microsoft.com/IE/feedback/details/838286/ie-11-incorrectly-reports-dom-element-sizes-in-fullscreen-mode-when-fullscreened-element-is-within-an-iframe + // -We should consider document.msFullscreenEnabled when they get their + // -element sizing corrected. Ref. https://connect.microsoft.com/IE/feedback/details/838286/ie-11-incorrectly-reports-dom-element-sizes-in-fullscreen-mode-when-fullscreened-element-is-within-an-iframe + // Update: Seems to be no need as they've moved on to Webkit } // Deprecated variable, kept to maintain backwards compatability