EDUCATIC
/
h5p-php-library
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Prevent DOM pollution when having many confirmation dialogs. 

Append confirmation dialog on show and detach it on hide.
HFJ-1969
pull/23/head
Thomas Marstrander 2016-05-31 10:19:07 +02:00
parent c6b3b06a97
commit 0a63d123cf
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
js/h5p-confirmation-dialog.js
View File

@ -128,14 +128,12 @@ H5P.ConfirmationDialog = (function (EventDispatcher) {
var wrapperElement; var wrapperElement;
/** /**
* Append confirmation dialog * Set parent of confirmation dialog
* @param {HTMLElement} wrapper * @param {HTMLElement} wrapper
* @returns {H5P.ConfirmationDialog} * @returns {H5P.ConfirmationDialog}
*/ */
this.appendTo = function (wrapper) { this.appendTo = function (wrapper) {
wrapper.appendChild(popupBackground);
wrapperElement = wrapper; wrapperElement = wrapper;
return this; return this;
}; };
@ -169,6 +167,7 @@ H5P.ConfirmationDialog = (function (EventDispatcher) {
* @returns {H5P.ConfirmationDialog} * @returns {H5P.ConfirmationDialog}
*/ */
this.show = function (offsetTop) { this.show = function (offsetTop) {
wrapperElement.appendChild(popupBackground);
popupBackground.classList.remove('hidden'); popupBackground.classList.remove('hidden');
fitToContainer(offsetTop); fitToContainer(offsetTop);
setTimeout(function () { setTimeout(function () {
@ -202,6 +201,7 @@ H5P.ConfirmationDialog = (function (EventDispatcher) {
popup.classList.add('hidden'); popup.classList.add('hidden');
setTimeout(function () { setTimeout(function () {
popupBackground.classList.add('hidden'); popupBackground.classList.add('hidden');
wrapperElement.removeChild(popupBackground);
}, 100); }, 100);
return this; return this;